Typo in Extension class name

[JeremyMahieu]

Proposed Changes

Rename IModelExsentions to IModelExtensions like the filename and the correct spelling.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

• Bug fix (non-breaking change which fixes issue #NNNN)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause an observable behavior change in existing systems)
• Documentation improvements (corrections, new content, etc)
• Cosmetic change (whitespace, formatting, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

• I have read the CONTRIBUTING.md document
• I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
• All tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)
• Any dependent changes have been merged and published in related repositories

[michaelklishin]

Curiously this does not affect the APIApprovals test 👍

[JeremyMahieu]

Curiously this does not affect the APIApprovals test 👍

Because I updated the APIApproval.Approve.verified.txt file, no?

[michaelklishin]

@astove ah, I see what the name of the second file is now, thanks 😅 This can only go into 7.0 as it technically it is a breaking public API change.

[lukebakken]

My vote is that this should be in 6.2 as it is a bug, even though it's a breaking change. @bording ?

[bording]

So this is interesting because this class is for holding extension methods. That means people are unlikely to be directly referencing the class in their code, so fixing it is not likely to be a compile-time break.

However it would be a binary breaking change, so existing assemblies would break at runtime with this fix in place.

I vote for keeping this in 7.0.0 only since it does have the potential to break people, and they likely can't see the typo in their code in the first place.

[lukebakken]

OK!