Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running Tests docs: quotes for setting env vars in windows #921

Merged
merged 2 commits into from
Jul 31, 2020
Merged

Running Tests docs: quotes for setting env vars in windows #921

merged 2 commits into from
Jul 31, 2020

Conversation

JeremyMahieu
Copy link
Contributor

Proposed Changes

Place quotes in the correct location. PR #896 was wrong. This should be correct now. Doing it like it is written in the docks now leads to errors because it's already quoted in the code so you end up with tripple quotes.
args = $"/c \"\"{ctl}\" {args}\"";

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

@lukebakken lukebakken added this to the 6.2.0 milestone Jul 31, 2020
@lukebakken lukebakken self-assigned this Jul 31, 2020
@lukebakken
Copy link
Contributor

Checking concourse now

@lukebakken lukebakken merged commit 6f65923 into rabbitmq:master Jul 31, 2020
lukebakken added a commit that referenced this pull request Jul 31, 2020
Running Tests docs: quotes for setting env vars in windows

(cherry picked from commit 6f65923)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants