Implement BasicPublishBatch with ReadOnlyMemory

[danielmarbach]

Proposed Changes

Alternative to #816

It seems that BasicPublishBatch doesn't support yet ReadOnlyMemory<byte>. This is a proposal to add it in a non-breaking way, which could be added in 6.2. Later the extension method can become the interface method in v7 because there the breaking change can be made.

wasn't sure if the extension method needs to be included in the ApiGen

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

• Bug fix (non-breaking change which fixes issue #NNNN)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause an observable behavior change in existing systems)
• Documentation improvements (corrections, new content, etc)
• Cosmetic change (whitespace, formatting, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

• I have read the CONTRIBUTING.md document
• I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
• All tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)
• Any dependent changes have been merged and published in related repositories

Further Comments

[danielmarbach]

@lukebakken @michaelklishin @stebet any thoughts on this? It also shows an example of how things can be evolved in non-breaking ways if necessary

[stebet]

@lukebakken @michaelklishin @stebet any thoughts on this? It also shows an example of how things can be evolved in non-breaking ways if necessary

I like it, LGTM :)

[michaelklishin]

@danielmarbach 👍 Thank you!

[danielmarbach]

Rebased