Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete AutoClose from SessionManager #852

Merged
merged 1 commit into from
May 26, 2020

Conversation

Pliner
Copy link
Contributor

@Pliner Pliner commented May 26, 2020

Proposed Changes

It seems that SessionManager.AutoClose wasn't accidentally removed during removal of Connection.AutoClose.

Types of Changes

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

@Pliner Pliner marked this pull request as ready for review May 26, 2020 05:34
@michaelklishin michaelklishin merged commit 85729ce into rabbitmq:master May 26, 2020
@michaelklishin
Copy link
Member

Thank you!

@michaelklishin michaelklishin added this to the 7.0.0 milestone May 26, 2020
@lukebakken lukebakken modified the milestones: 8.0.0, 7.0.0 Mar 8, 2022
@Pliner Pliner deleted the auto-close-deletion branch December 2, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants