Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding BinaryPrimitives support for NETSTANDARD targets #851

Merged
merged 1 commit into from
May 26, 2020

Conversation

stebet
Copy link
Contributor

@stebet stebet commented May 25, 2020

Proposed Changes

This PR adds NETSTANDARD ifdefs for the binary serialization for more optimized code when targeting .NET Core applications. Thanks to @bollhals for the tip and the benchmarks showing greatly improved performance for those targets, which I had underestimated. See #801 for the discussion.

This does convolute the code a little bit (but not too much) and is mostly aimed at 6.X as these ifdefs can be removed for 7.0 later and we can just stick to the BinaryPrimitives method there.

Types of Changes

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

@michaelklishin michaelklishin merged commit 29f78bf into rabbitmq:master May 26, 2020
@michaelklishin michaelklishin added this to the 6.1.0 milestone May 26, 2020
michaelklishin added a commit that referenced this pull request May 26, 2020
Adding BinaryPrimitives support for NETSTANDARD targets

(cherry picked from commit 29f78bf)
@michaelklishin
Copy link
Member

Backported to 6.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants