Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on multiple frameworks #808

Merged
merged 6 commits into from
Apr 7, 2020

Conversation

lukebakken
Copy link
Contributor

@bording helpfully suggested this in this comment:

#804 (comment)

@bording helpfully suggested this in this comment:

#804 (comment)
@lukebakken lukebakken added this to the 6.0.0 milestone Apr 7, 2020
@lukebakken lukebakken self-assigned this Apr 7, 2020
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>netcoreapp3.1</TargetFramework>
<TargetFrameworks>net461;netcoreapp2.1</TargetFrameworks>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed that this went from netcoreapp3.1 to netcoreapp2.1. If you only want to test one .NET Core, then the latest LTS release seems to be the one to choose, so I'd keep it at netcoreapp3.1.

You could also do net461;netcoreapp3.1;netcoreapp2.1, but I'm not sure if that would be worth bothering with.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have considered switching our tutorials to netcoreapp3.1 but then had to revert it for unrelated reasons. Targeting the latest sounds good to me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that makes sense. We're going to test net461 on Windows only because testing that framework on Linux requires Mono which really who is going to be using at this point?!?!

@lukebakken lukebakken marked this pull request as ready for review April 7, 2020 18:24
@lukebakken lukebakken merged commit f8409df into master Apr 7, 2020
@lukebakken lukebakken deleted the lrb-run-tests-multiple-frameworks branch April 7, 2020 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants