Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reducing allocations when (de)serializing frames/commands. #732

Merged
merged 13 commits into from
Mar 4, 2020
Merged

Reducing allocations when (de)serializing frames/commands. #732

merged 13 commits into from
Mar 4, 2020

Commits on Mar 4, 2020

  1. Reducing memory usage when deserializing frames into commands.

    @lukebakken
    Stefán J. Sigurðarson authored and lukebakken committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    025b7e4 View commit details
    Browse the repository at this point in the history

  2. Cleaning up CommandAssembler.

    @lukebakken
    Stefán J. Sigurðarson authored and lukebakken committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    4069854 View commit details
    Browse the repository at this point in the history

  3. Using recycled memory buffers when serializing frames.

    @lukebakken
    Stefán J. Sigurðarson authored and lukebakken committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    549d99f View commit details
    Browse the repository at this point in the history

  4. Removing unused code.

    @stebet @lukebakken
    stebet authored and lukebakken committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    e9390a0 View commit details
    Browse the repository at this point in the history

  5. Getting rid of an unnecessary NetworkBinaryWriter in the socket handler.

    @stebet @lukebakken
    stebet authored and lukebakken committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    2a49674 View commit details
    Browse the repository at this point in the history

  6. Code cleanups.

    @stebet @lukebakken
    stebet authored and lukebakken committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    f33dd6c View commit details
    Browse the repository at this point in the history

  7. Recycling command buffers to reduce allocations when receiving messages.

    @stebet @lukebakken
    stebet authored and lukebakken committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    8bf9308 View commit details
    Browse the repository at this point in the history

  8. Removing unused variables and making readonly where possible.

    @lukebakken
    Stefán J. Sigurðarson authored and lukebakken committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    9e82efc View commit details
    Browse the repository at this point in the history

  9. Removing last usages of NetworkBinaryReader and NetworkBinaryWriter a… 

    …nd removing unused internal classes and tests. Adding NetworkByteOrder tests.
    @lukebakken
    Stefán J. Sigurðarson authored and lukebakken committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    3a2d8fc View commit details
    Browse the repository at this point in the history

  10. Use ReadOnlyMemory where possible.

    @lukebakken
    Stefán J. Sigurðarson authored and lukebakken committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    8778edf View commit details
    Browse the repository at this point in the history

  11. Removing the use of a BlockingCollection and replacing with Concurren… 

    …tQueue + SemaphoreSlim to get rid of a blocking wait for better concurrency.
    @lukebakken
    Stefán J. Sigurðarson authored and lukebakken committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    3847a76 View commit details
    Browse the repository at this point in the history

  12. Increasing buffer size for both send/receive for better throughput. 

    Removing use og SunchronizedList and replacing with just two longs to keep track of outstanding confirms.
    @lukebakken
    Stefán J. Sigurðarson authored and lukebakken committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    ff627be View commit details
    Browse the repository at this point in the history

  13. Cosmetic fixes, remove commented out code

    @lukebakken
    lukebakken committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    b1c16b4 View commit details
    Browse the repository at this point in the history