Byte conversion support #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| case 'A': | ||
| value = ReadArray(reader); | ||
| break; | ||
| case 'B': |
| WriteOctet(writer, (byte)'A'); | ||
| WriteArray(writer, val); | ||
| break; | ||
| case byte val: |
| break; | ||
| default: | ||
| throw new WireFormattingException( | ||
| $"Value of type '{value.GetType().Name}' cannot appear as table value", |
There was a problem hiding this comment.
Some exception details
|
Thank you for your ongoing pull requests! It's not clear what's in scope for this PR. Adding some tests would help. Please make sure you have read the AMQP 0-9-1 Errata document. |
|
Yes, i got 'B' for byte from this document |
michaelklishin
approved these changes
Mar 20, 2019
|
Thank you. I will cherry-pick to |
michaelklishin
added a commit
that referenced
this pull request
Mar 20, 2019
Byte conversion support (cherry picked from commit c343098)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
I tried to add byte conversion support for arguments. but this not a final version. Solutions are:
Motivation:
RabbitMQ has
x-max-priorityfor queues,x-priorityfor consumers and priority inIBasicPropertiesfor producers, but for them is ok. Commonly i used them to balance messages.Priorities is in 1...255 range and perfectly suites to byte, but when i tried wrap arguments with byte extensions i got a
WireFormattingException(Value cannot appear as table value) and nothing more. Boxing int for priority works fine.Usage: https://gist.github.com/sergeyshaykhullin/bca8964c0ebbd5a8737a559bcb0287e3
If English isn't your first language, don't worry about it and try to
communicate the problem you are trying to solve to the best of your abilities.
As long as we can understand the intent, it's all good.
Types of Changes
Checklist
CONTRIBUTING.mddocumentFurther Comments
There are possible breaking changes, f.e. new version writes 'B', but old version doesnt know about it and throws
SyntaxErrorDocs https://www.rabbitmq.com/priority.html has
For 'x-max-priority' -
This argument should be a positive integer between 1 and 255For
x-priority-The message priority field is defined as an unsigned byte, so in practice priorities should be between 0 and 255.IBasicProperties has
byteprioritySo maybe it can help someone in future