Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove two unnecessary .Cast<>() usages #1577

Merged
merged 1 commit into from
May 24, 2024

Conversation

lukebakken
Copy link
Contributor

Noticed by @paulomorgado in #1233

@lukebakken lukebakken added this to the 7.0.0 milestone May 23, 2024
@lukebakken lukebakken self-assigned this May 23, 2024
@lukebakken lukebakken force-pushed the lukebakken/review-allocations branch from f541d82 to 73d7541 Compare May 23, 2024 19:25
@paulomorgado
Copy link
Contributor

Anytime you see System.Linq in your code or System.Linq.Enumerable in your profiling you should question that and benchmark.

If it's using a delegate or you have more than one operator, it's most likely a bad idea to use.

@lukebakken lukebakken force-pushed the lukebakken/review-allocations branch from 73d7541 to 393032b Compare May 24, 2024 13:02
@lukebakken lukebakken merged commit bf89475 into main May 24, 2024
11 checks passed
@lukebakken lukebakken deleted the lukebakken/review-allocations branch May 24, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants