Address lack of Socket read timeout for async reads #1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebakken
force-pushed
the
rabbitmq-dotnet-client-1492
branch
2 times, most recently
from
b401bb8
to
903a590
Compare
Fixes #1492 * Add dedicated test class for Toxiproxy * Start Toxiproxy via docker on GHA ubuntu runner * Start Toxiproxy in same Powershell session as `dotnet test` on GHA windows runner * Add toxiproxy-netcore as a submodule so that we can strong-name it. * Remove use of socket read timeout, and depend on heartbeats instead. * Remove duplicate tests * Use `ConcurrentBag` where necessary
lukebakken
force-pushed
the
rabbitmq-dotnet-client-1492
branch
from
903a590
to
eeaf91b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1492