Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1429 in 6.x #1432

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Fix #1429 in 6.x #1432

merged 1 commit into from
Dec 1, 2023

Conversation

lukebakken
Copy link
Contributor

References #1431

@lukebakken lukebakken self-assigned this Nov 29, 2023
@lukebakken lukebakken added this to the 6.8.0 milestone Nov 29, 2023
@lukebakken lukebakken force-pushed the rabbitmq-dotnet-client-1429-6.x branch 2 times, most recently from 2253184 to 37c7e9e Compare November 29, 2023 20:58
@lukebakken
Fixes #1429 for 6.x
27d5fb8 
See #1431

* Modify test program to demonstrate the issue
* Fix underlying issue by allowing multiple Register calls for the same instance of ICredentialsProvider
@lukebakken lukebakken force-pushed the rabbitmq-dotnet-client-1429-6.x branch from 37c7e9e to 27d5fb8 Compare November 30, 2023 16:29
@lukebakken
Copy link
Contributor Author

@michaelklishin @Gsantomaggio I ran the test procedure as outlined here:

https://github.com/rabbitmq/rabbitmq-dotnet-client/blob/6.x/projects/TestApplications/OAuth2/README.md

In the main branch, the above procedure is automated and run by the OAuth2 GHA workflow.

@lukebakken lukebakken merged commit 3b4b222 into 6.x Dec 1, 2023
3 checks passed
@lukebakken lukebakken deleted the rabbitmq-dotnet-client-1429-6.x branch December 1, 2023 21:07
@lukebakken lukebakken modified the milestones: 6.8.0, 7.0.0, 6.7.0 Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelklishin michaelklishin Awaiting requested review from michaelklishin

@Gsantomaggio Gsantomaggio Awaiting requested review from Gsantomaggio

Assignees

@lukebakken lukebakken

Labels
None yet
Projects
None yet
Milestone
6.8.0
Development

Successfully merging this pull request may close these issues.
1 participant
@lukebakken