Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that the underlying timer for Task.Delay is canceled. #1426

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

lukebakken
Copy link
Contributor

@lukebakken lukebakken commented Nov 20, 2023

Part of the fix to #1425

@lukebakken lukebakken added this to the 7.0.0 milestone Nov 20, 2023
@lukebakken lukebakken self-assigned this Nov 20, 2023
@lukebakken lukebakken marked this pull request as ready for review November 21, 2023 14:17
Part of the fix to #1425

* Add EnsureCompleted task extensions.
* Don't use compiler shenanigans for AsyncRpcContinuation
* Add Ignore() extension to ignore the results of a Task
@lukebakken lukebakken merged commit 5b2cd95 into main Nov 22, 2023
11 checks passed
@lukebakken lukebakken deleted the rabbitmq-dotnet-client-1425 branch November 22, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants