Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trimming and AOT compatibility #1411

Merged
merged 1 commit into from
Dec 27, 2023
Merged

Trimming and AOT compatibility #1411

merged 1 commit into from
Dec 27, 2023

Conversation

eerhardt
Copy link
Contributor

Proposed Changes

Allow RabbitMQ.Client to be used in trimmed and AOT'd apps with no warnings.

Resolve the trim warning coming from RabbitMqClientEventSource.Error. Preserve the properties of RabbitMqExceptionDetail and suppress the warning.

The TimerBasedCredentialRefresherEventSource has warnings as well, but these can be suppressed because the parameters are primitive. In .NET 8 these warnings no longer need to be suppressed because of dotnet/runtime#83751.

Fix #1410

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (enabled the trim analyzer)
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

@lukebakken lukebakken added this to the 6.7.0 milestone Oct 31, 2023
@lukebakken lukebakken self-assigned this Oct 31, 2023
@lukebakken lukebakken self-requested a review October 31, 2023 20:08
@lukebakken lukebakken modified the milestones: 6.7.0, 6.8.0 Nov 15, 2023
@lukebakken lukebakken modified the milestones: 6.8.0, 6.9.0 Dec 5, 2023
Resolve the trim warning coming from RabbitMqClientEventSource.Error. Preserve the properties of RabbitMqExceptionDetail and suppress the warning.

The TimerBasedCredentialRefresherEventSource has warnings as well, but these can be suppressed because the parameters are primitive. In .NET 8 these warnings no longer need to be suppressed because of dotnet/runtime#83751.

Fix rabbitmq#1410
@lukebakken lukebakken merged commit 317a633 into rabbitmq:main Dec 27, 2023
11 checks passed
lukebakken added a commit that referenced this pull request Dec 27, 2023
lukebakken added a commit that referenced this pull request Dec 27, 2023
lukebakken added a commit that referenced this pull request Jan 8, 2024
lukebakken added a commit that referenced this pull request Jan 8, 2024
@eerhardt eerhardt deleted the Fix1410 branch January 12, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trimming and AOT compatibility of this library
2 participants