Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target netstandard2.1 #1320

Closed
wants to merge 1 commit into from
Closed

Conversation

michaelklishin
Copy link
Member

In main it feels appropriate to target a supported modern LTS version of .NET.

Per discussion with @Zerpet.

@bording
Copy link
Collaborator

bording commented Mar 21, 2023

This is not a good idea. netstandard2.1 is a dead end that is only support by .NET Core 3.1 and newer.

.NET Core 3.1 is already out of support, so you're already targeting net6.0, which is the oldest support .NET version.

Another thing to consider here is the idea of removing support for .NET Framework, which is another thing this PR is doing. This is going to be controversial, and might be too aggressive.

@lukebakken
Copy link
Contributor

We can't make the changes in this PR. Check out this long discussion - #1189

@michaelklishin @Zerpet we should be able to use conditionals in the .csproj files to make things more OS X friendly.

@lukebakken lukebakken closed this Mar 21, 2023
@michaelklishin michaelklishin deleted the mk-bump-minimum-sdk-target branch March 21, 2023 21:08
@michaelklishin
Copy link
Member Author

@bording interesting, I have seen a page on one of Microsoft sites that lists netstandard2.1 as supported by .NET 6.0.

@bording
Copy link
Collaborator

bording commented Mar 21, 2023

@bording interesting, I have seen a page on one of Microsoft sites that lists netstandard2.1 as supported by .NET 6.0.

It is, but there just isn't a point to targeting it. Not enough things support it, so you're better off just targeting net6.0 directly at this point.

@stebet
Copy link
Contributor

stebet commented Mar 22, 2023

I agree with @bording. Just target 'net6.0'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants