Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom filtering and exception handling to topology recovery on 6.x #1316

Conversation

rosca-sabina
Copy link
Contributor

Proposed Changes

This is a backport of #1312, to fix #658 on 6.x.

Types of Changes

What types of changes does your code introduce to this project?

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

@rosca-sabina rosca-sabina changed the title Feature/658 add filtering to topology recovery 6.x Add custom filtering and exception handling to topology recovery on 6.x Mar 20, 2023
@lukebakken lukebakken self-assigned this Mar 20, 2023
@lukebakken lukebakken added this to the 6.5.0 milestone Mar 20, 2023
@Zerpet
Copy link
Contributor

Zerpet commented Mar 21, 2023

Concourse build failed on test TestBasicNackAfterChannelRecovery, which did not fail in GitHub Actions. I re-triggered the job. Actions build on windows failed on test TestWaitForConfirmsWithEvents. Actions failure seems unrelated to this PR and Concourse looks like a flake.

@Zerpet Zerpet merged commit bf7d538 into rabbitmq:6.x Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants