Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add related headers to streams feature in Headers.cs #1201

Merged
merged 1 commit into from
May 6, 2022

Conversation

ArminShoeibi
Copy link
Contributor

@ArminShoeibi ArminShoeibi commented Apr 30, 2022

Proposed Changes

Hello there, I have added some headers that are related to streams feature
Thanks in advance.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

@pivotal-cla
Copy link

@ArminShoeibi Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@ArminShoeibi Thank you for signing the Contributor License Agreement!

michaelklishin
michaelklishin previously approved these changes Apr 30, 2022
@lukebakken lukebakken self-assigned this May 6, 2022
@lukebakken lukebakken added this to the 7.0.0 milestone May 6, 2022
@lukebakken lukebakken force-pushed the feature/add-streams-headers branch from 48df351 to c87f508 Compare May 6, 2022 16:25
Copy link
Contributor

@lukebakken lukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lukebakken lukebakken merged commit ded6f51 into rabbitmq:main May 6, 2022
@ArminShoeibi ArminShoeibi deleted the feature/add-streams-headers branch May 7, 2022 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants