Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove batch publishing as its optimizations are now performed for "regular" publishes/outgoing frames #1028

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

bollhals
Copy link
Contributor

Proposed Changes

Deletes the publish batch functionality. fixes part of #963

Types of Changes

  • Bug fix (non-breaking change which fixes issue 8.0 Proposal: Remove WaitForConfirms and PublishBatch methods/APIs #963 )
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

Since we queue the publishes internally, there isn't really a need for a batch functionality. If a customer still wants it, it can easily built on top of the normal BasicPublish in customer code.

@michaelklishin michaelklishin changed the title delete publish batch Remove batch publishing as its optimizations are now performed for "regular" publishes/outgoing frames Mar 16, 2021
@michaelklishin michaelklishin merged commit 5c4c6dd into rabbitmq:master Mar 16, 2021
@bollhals bollhals deleted the feature/delete.batch branch March 16, 2021 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants