Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove socket.poll #1018

Merged
merged 1 commit into from
Feb 22, 2021
Merged

Conversation

bollhals
Copy link
Contributor

Proposed Changes

Removes the call to Socket.Poll as to my knowledge this shouldn't be needed, especially because we don't check for the result...

Types of Changes

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

@michaelklishin
Copy link
Member

The poll was introduced in d74b821. @stebet do you agree to remove it?

@stebet
Copy link
Contributor

stebet commented Feb 21, 2021

It wasn't introduced there. Simply moved from the code elsewhere. Since we only have one thread writing to the socket, I don't think the poll is needed.

@michaelklishin michaelklishin merged commit 7b26b34 into rabbitmq:master Feb 22, 2021
@michaelklishin
Copy link
Member

Great, thank you both for walking me through this.

@bollhals bollhals deleted the feature/socket.poll branch February 22, 2021 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants