Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify connection recovery #1004

Merged

Conversation

bollhals
Copy link
Contributor

Proposed Changes

Simplifies how to recover a connection by

  • getting rid of the channel for the recovery commands => replaced by recovery method
  • only allocates when a recovery is required => reducing overall startup allocations
  • splitting recovery in its own partial class cs file for grouping purpose

Types of Changes

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

I kind of like the split to partial classes for grouping for cases where we can't break up the implementation (big classes like model or connection). If this is not what we want, I can copy them back.

@bollhals bollhals marked this pull request as draft January 19, 2021 23:37
@bollhals bollhals marked this pull request as ready for review January 20, 2021 15:24
@michaelklishin michaelklishin changed the title simplify connection recovery Simplify connection recovery Jan 20, 2021
@michaelklishin michaelklishin merged commit e3cb8ec into rabbitmq:master Jan 20, 2021
@michaelklishin
Copy link
Member

Thank you!

@bollhals bollhals deleted the feature/simplifyConnRecovery branch January 20, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants