Stop disabling management tcp listener when tls enabled #487
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #482
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Summary Of Changes
I have thought about including
management.tcp.port = 15672
as the default configuration and deleting the key ifdisableNonTLSListeners
is set to true. However, that will unfortunately change all clusters's rabbitmq.conf (no matter its tls configurations), that would be a breaking behavior. Here,management.tcp.port = 15672
is only set if people enable tls and do not setdisableNonTLSListeners
to true.Additional Context
Local Testing
Added unit and system tests for the case.