Generate single manifest for installation #(228) #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshac
force-pushed
the
1-step-install
branch
from
0b11583
to
50cbed3
Compare
harshac
commented
Aug 28, 2020
Zerpet
force-pushed
the
1-step-install
branch
from
50cbed3
to
dbbeae3
Compare
It uses resources from sibling directories instead of copying them over. The Operator image can be kustomized via 'kustomize edit set image' before calling the make target.
Zerpet
force-pushed
the
1-step-install
branch
from
dbbeae3
to
6e8a471
Compare
Closed
Closed
coro
approved these changes
Sep 18, 2020
|
Checks are green 🟢 and with two approvals ✅ I'm merging this PR 🚀 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates #228
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Summary Of Changes
Adapted
generate-installation-manifestmake target to generate a single-file manifest with all the resources required to deploy Cluster Operator. The image name and tag is hard-coded, however it can be (and it's expected to) changed usingkustomize edit set image <..>command. The pipeline will run a similarkustomizecommand to generate release specific, versioned, manifest files.Additional Context
This change is the first step to accomplish 1-step install. Second step is to adapt the pipeline to leverage this change and produce versioned manifest files.
Local Testing
N/A no changes to code or to how we deploy.
Edit: @Zerpet picked this PR and added some changes.