updating cluster operator crd #1604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielePalaia
force-pushed
the
update_cluster_crd
branch
from
ab30638
to
d6c13f6
Compare
|
Good spot (also just bitten by it and found same cause) - apologies it was missing from that PR, I didn't know to add it there! I am wondering if there is a step or test we could add to generate the crds and confirm the files match what's checked in? That would avoid it coming up again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cluster operator crd is currently not updated.
make manifests is adding the pkiRootPath field.
This was probably a step missing in:
be674d6