On new release generate -amd64 and -arm64 release versions #1348
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary Of Changes
Previously -amd64 and -arm64 images were created with tags sha-amd64 and sha-arm64.
For our carvel-pipeline to work properly is convinient to have images tagged with version-amd64 and version-arm64 (ex 2.2.0-amd64 and 2.2.0-arm64 when a new release happens).
Also:
type=semver,pattern={{major}}.{{minor}}
type=semver,pattern={{major}},enable=${{ !startsWith(github.ref, 'refs/tags/v0.') }}
seems not necessary as these created tags of type 2.2 and 2
for example https://hub.docker.com/r/rabbitmqoperator/cluster-operator/tags?page=1&name=2.2
I have tested these modifications cloning the repo https://github.com/DanielePalaia/cluster-operator/blob/main/.github/workflows/build-test-publish.yml and using my dockerhub account:
https://hub.docker.com/repository/docker/danielepalaia/cluster-operator/general
Additional Context
Local Testing
Please ensure you run the unit, integration and system tests before approving the PR.
To run the unit and integration tests:
You will need to target a k8s cluster and have the operator deployed for running the system tests.
For example, for a Kubernetes context named
dev-bunny
: