Remove unused method UpdateRequiresStsRestart

rabbitmq · Oct 19, 2020 · 63ea25c · 63ea25c
1 parent d70e0c3
commit 63ea25c
Show file tree

Hide file tree

Showing 11 changed files with 0 additions and 41 deletions.
diff --git a/internal/resource/client_service.go b/internal/resource/client_service.go
@@ -35,10 +35,6 @@ type ClientServiceBuilder struct {
 	Scheme   *runtime.Scheme
 }
 
-func (builder *ClientServiceBuilder) UpdateRequiresStsRestart() bool {
-	return false
-}
-
 func (builder *ClientServiceBuilder) Build() (runtime.Object, error) {
 	return &corev1.Service{
 		ObjectMeta: metav1.ObjectMeta{

diff --git a/internal/resource/configmap.go b/internal/resource/configmap.go
@@ -52,10 +52,6 @@ func (builder *RabbitmqResourceBuilder) ServerConfigMap() *ServerConfigMapBuilde
 	}
 }
 
-func (builder *ServerConfigMapBuilder) UpdateRequiresStsRestart() bool {
-	return true // because rabbitmq.conf and advanced.config changes take effect only after a node restart
-}
-
 func (builder *ServerConfigMapBuilder) Update(object runtime.Object) error {
 	configMap := object.(*corev1.ConfigMap)
 	configMap.Labels = metadata.GetLabels(builder.Instance.Name, builder.Instance.Labels)

diff --git a/internal/resource/default_user_secret.go b/internal/resource/default_user_secret.go
@@ -81,10 +81,6 @@ func (builder *DefaultUserSecretBuilder) Update(object runtime.Object) error {
 	return nil
 }
 
-func (builder *DefaultUserSecretBuilder) UpdateRequiresStsRestart() bool {
-	return false
-}
-
 func generateDefaultUserConf(username, password string) ([]byte, error) {
 	ini.PrettySection = false // Remove trailing new line because default_user.conf has only a default section.
 	cfg, err := ini.Load([]byte{})

diff --git a/internal/resource/erlang_cookie.go b/internal/resource/erlang_cookie.go
@@ -38,10 +38,6 @@ func (builder *RabbitmqResourceBuilder) ErlangCookie() *ErlangCookieBuilder {
 	}
 }
 
-func (builder *ErlangCookieBuilder) UpdateRequiresStsRestart() bool {
-	return false
-}
-
 func (builder *ErlangCookieBuilder) Build() (runtime.Object, error) {
 	cookie, err := randomEncodedString(24)
 	if err != nil {

diff --git a/internal/resource/headless_service.go b/internal/resource/headless_service.go
@@ -35,10 +35,6 @@ func (builder *RabbitmqResourceBuilder) HeadlessService() *HeadlessServiceBuilde
 	}
 }
 
-func (builder *HeadlessServiceBuilder) UpdateRequiresStsRestart() bool {
-	return false
-}
-
 func (builder *HeadlessServiceBuilder) Build() (runtime.Object, error) {
 	return &corev1.Service{
 		ObjectMeta: metav1.ObjectMeta{

diff --git a/internal/resource/rabbitmq_plugins.go b/internal/resource/rabbitmq_plugins.go
@@ -67,10 +67,6 @@ func (builder *RabbitmqResourceBuilder) RabbitmqPluginsConfigMap() *RabbitmqPlug
 	}
 }
 
-func (builder *RabbitmqPluginsConfigMapBuilder) UpdateRequiresStsRestart() bool {
-	return false
-}
-
 func (builder *RabbitmqPluginsConfigMapBuilder) Update(object runtime.Object) error {
 	configMap := object.(*corev1.ConfigMap)
 	configMap.Labels = metadata.GetLabels(builder.Instance.Name, builder.Instance.Labels)

diff --git a/internal/resource/rabbitmq_resource_builder.go b/internal/resource/rabbitmq_resource_builder.go
@@ -22,7 +22,6 @@ type RabbitmqResourceBuilder struct {
 type ResourceBuilder interface {
 	Update(runtime.Object) error
 	Build() (runtime.Object, error)
-	UpdateRequiresStsRestart() bool
 }
 
 func (builder *RabbitmqResourceBuilder) ResourceBuilders() ([]ResourceBuilder, error) {

diff --git a/internal/resource/role.go b/internal/resource/role.go
@@ -35,10 +35,6 @@ func (builder *RabbitmqResourceBuilder) Role() *RoleBuilder {
 	}
 }
 
-func (builder *RoleBuilder) UpdateRequiresStsRestart() bool {
-	return false
-}
-
 func (builder *RoleBuilder) Update(object runtime.Object) error {
 	role := object.(*rbacv1.Role)
 	role.Labels = metadata.GetLabels(builder.Instance.Name, builder.Instance.Labels)

diff --git a/internal/resource/role_binding.go b/internal/resource/role_binding.go
@@ -36,10 +36,6 @@ func (builder *RabbitmqResourceBuilder) RoleBinding() *RoleBindingBuilder {
 	}
 }
 
-func (builder *RoleBindingBuilder) UpdateRequiresStsRestart() bool {
-	return false
-}
-
 func (builder *RoleBindingBuilder) Update(object runtime.Object) error {
 	roleBinding := object.(*rbacv1.RoleBinding)
 	roleBinding.Labels = metadata.GetLabels(builder.Instance.Name, builder.Instance.Labels)

diff --git a/internal/resource/service_account.go b/internal/resource/service_account.go
@@ -35,10 +35,6 @@ func (builder *RabbitmqResourceBuilder) ServiceAccount() *ServiceAccountBuilder
 	}
 }
 
-func (builder *ServiceAccountBuilder) UpdateRequiresStsRestart() bool {
-	return false
-}
-
 func (builder *ServiceAccountBuilder) Update(object runtime.Object) error {
 	serviceAccount := object.(*corev1.ServiceAccount)
 	serviceAccount.Labels = metadata.GetLabels(builder.Instance.Name, builder.Instance.Labels)

diff --git a/internal/resource/statefulset.go b/internal/resource/statefulset.go
@@ -45,10 +45,6 @@ type StatefulSetBuilder struct {
 	Scheme   *runtime.Scheme
 }
 
-func (builder *StatefulSetBuilder) UpdateRequiresStsRestart() bool {
-	return false
-}
-
 func (builder *StatefulSetBuilder) Build() (runtime.Object, error) {
 	// PVC, ServiceName & Selector: can't be updated without deleting the statefulset
 	pvc, err := persistentVolumeClaim(builder.Instance, builder.Scheme)