Resolve all cookstyle warnings #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is unused and there's no point in including it here Signed-off-by: Tim Smith <tsmith@chef.io>
opensuse has been replaced by opensuseleap which is 42 and 15. There's no support opensuse distro that's supported now Signed-off-by: Tim Smith <tsmith@chef.io>
ChefSpec generates these automatically now Signed-off-by: Tim Smith <tsmith@chef.io>
Chef does this for you already Signed-off-by: Tim Smith <tsmith@chef.io>
This is the default in Chef 13 now and it's an empty method in the chef codebase Signed-off-by: Tim Smith <tsmith@chef.io>
These were not platform families Signed-off-by: Tim Smith <tsmith@chef.io>
These were all platforms not platform families Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
node.normal doesn't make sense here Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
This makes it more clear what you're actually trying to set since 0755 is 755 in ruby land Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
|
Thank you. Any chance you can also submit a version of this for |
michaelklishin
requested changes
Dec 10, 2019
| @@ -17,8 +17,6 @@ | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
| # | |||
|
|
|||
| actions :add, :delete, :set_permissions, :clear_permissions, :set_tags, :clear_tags, :change_password | |||
There was a problem hiding this comment.
This line's removal leads to Kitchen failures:
================================================================================
Recipe Compile Error in /opt/kitchen/cache/cookbooks/rabbitmq/recipes/users.rb
================================================================================
Chef::Exceptions::ValidationFailed
----------------------------------
Option action must be equal to one of: :nothing, :add! You passed :set_tags.
Cookbook Trace:
---------------
/opt/kitchen/cache/cookbooks/rabbitmq/recipes/users.rb:38:in `block (2 levels) in from_file'
/opt/kitchen/cache/cookbooks/rabbitmq/recipes/users.rb:35:in `block in from_file'
/opt/kitchen/cache/cookbooks/rabbitmq/recipes/users.rb:27:in `each'
/opt/kitchen/cache/cookbooks/rabbitmq/recipes/users.rb:27:in `from_file'
Relevant File Content:
----------------------
/opt/kitchen/cache/cookbooks/rabbitmq/recipes/users.rb:
31: action :add
32:
33: notifies :set_tags, "rabbitmq_user[set-tags-#{user['name']}]", :immediately
34: end
35: rabbitmq_user "set-tags-#{user['name']}" do
36: user user['name']
37: tag user['tag']
38>> action :set_tags
39: end
40: user['rights'].each do |r|
41: rabbitmq_user "set-perms-#{user['name']}-vhost-#{Array(r['vhost']).join().tr('/', '_')}" do
42: user user['name']
43: vhost r['vhost']
44: permissions "#{r['conf']} #{r['write']} #{r['read']}"
45: action :set_permissions
46: end
47: end
System Info:
------------
chef_version=15.5.17
platform=ubuntu
platform_version=16.04
ruby=ruby 2.6.5p114 (2019-10-01 revision 67812) [x86_64-linux]
program_name=/opt/chef/embedded/bin/chef-client
executable=/opt/chef/embedded/bin/chef-client
|
I restored resource actions and tests started passing. Thank you. Would be great to have a version of this (with my patch) for |
|
Yep it looks like we need to keep the actions for LWRPs after all. That was the original behavior in cookstyle and I've reverted it here: chef/cookstyle#436 |
|
Cherry-picked to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some very funky stuff going on in this cookbook and a lot of code that could be removed. This resolves all the current Cookstyle warnings with cookstyle on the master branch.