Rework how we autocorrect allowed actions #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tas50
force-pushed
the
action_cleanup
branch
3 times, most recently
from
bffb5b2
to
4d36217
Compare
| MSG = 'The allowed actions of a resource can be set with the "allowed_actions" helper instead of using the initialize method.'.freeze | ||
|
|
||
| def on_def(node) | ||
| return unless node.method_name == :initialize |
There was a problem hiding this comment.
There's no reasonable case where someone might define these outside of initialize is there?
There was a problem hiding this comment.
If they're using them outside the intialize that's a different case and we want to avoid breaking their code. It could just be any old library setting those values and fixing that would be bad.
marcparadise
approved these changes
Dec 11, 2019
Don't remove them if we're not in a custom resource Consider the custom resource cop to be ChefRedundant since there has never been a need for this code in a custom resource. It's just leftover redundant junk Add a new cop ChefModernize/AllowedActionsFromInitialize that pulls the allowed_actions out of initialize methods in HWRPs. This gets folks closer to LWRPs which gets them closer to custom resources Signed-off-by: Tim Smith <tsmith@chef.io>
tas50
force-pushed
the
action_cleanup
branch
from
4d36217
to
42c4205
Compare
Signed-off-by: Tim Smith <tsmith@chef.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't remove them if we're not in a custom resource
Consider the custom resource cop to be ChefRedundant since there has never been a need for this code in a custom resource. It's just leftover redundant junk
Add a new cop ChefModernize/AllowedActionsFromInitialize that pulls the allowed_actions out of initialize methods in HWRPs. This gets folks closer to LWRPs which gets them closer to custom resources
Signed-off-by: Tim Smith tsmith@chef.io