Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if contracts needs to be build before deploy #246

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

AlexD10S
Copy link
Collaborator

@AlexD10S AlexD10S commented Jul 8, 2024

A bug was found when running the pop up contract. The check to determine if the contract had been built was failing, causing the contract to be rebuilt every time.
I have added the fix and included a test to ensure this issue does not occur again.

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 8 lines in your changes missing coverage. Please review.

Project coverage is 70.42%. Comparing base (a252c45) to head (b9cfe17).

@@            Coverage Diff             @@
##             main     #246      +/-   ##
==========================================
+ Coverage   70.40%   70.42%   +0.02%     
==========================================
  Files          47       47              
  Lines        7516     7538      +22     
  Branches     7516     7538      +22     
==========================================
+ Hits         5292     5309      +17     
+ Misses       1337     1335       -2     
- Partials      887      894       +7     
Files Coverage Δ
crates/pop-cli/src/commands/up/contract.rs 26.33% <69.23%> (+6.04%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Contributor

@evilrobot-01 evilrobot-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean!

@AlexD10S AlexD10S merged commit 31cb3da into main Jul 9, 2024
14 of 15 checks passed
@AlexD10S AlexD10S deleted the fix/build-contract-when-deploy branch July 9, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants