Skip to content

Commit

Permalink
Fix #767
Browse files Browse the repository at this point in the history
  • Loading branch information
Jean-Romain committed Jul 4, 2024
1 parent ec3ff23 commit cc941d7
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 21 deletions.
25 changes: 5 additions & 20 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,20 +1,5 @@
## Test environments

* Linux Mint 20 (Ubuntu 20.04), R 4.1.2 with g++
* Windows Server 2009 via github CI
* Ubuntu 20.04 R-release via github CI
* Ubuntu 20.04 R-devel via github CI
* Windows Server 2008 R-release via win-builder
* Windows Server 2008 R-devel via win-builder
* MacOS r-release via win-builder

## R CMD check results

0 ERRORs | 0 WARNINGs | 1 NOTE
- checking installed package size ... NOTE
This is compiled code in the libs/ directory.

## Downstream dependencies

We checked 5 reverse dependencies by running R CMD check with this version installed.
We did not see any new problems.
- Remove the use of some `boost` tools to fix LLVM 19
- Remove some features to fix non-API calls
- Fix C++20 compilation with gcc12 additional issue
- Fix noSuggests additional issue
- Fix Intel additional issue by changing std::stable_sort to std::sort.
2 changes: 1 addition & 1 deletion inst/include/lidR/QuadTree.h
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,7 @@ inline void QuadTree::harvest_knn(Node::Quadnode* node, Bucket::KnnBucket& bucke
double d[4];
std::vector<unsigned char> idx = {0,1,2,3};
for(auto i : idx) d[i] = distance(&heap[node->firstChild + i], bucket.pref);
std::stable_sort(idx.begin(), idx.end(), [&d](size_t i1, size_t i2) {return d[i1] < d[i2];});
std::sort(idx.begin(), idx.end(), [&d](size_t i1, size_t i2) {return d[i1] < d[i2];});

for(auto i : idx)
{
Expand Down

0 comments on commit cc941d7

Please sign in to comment.