Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old and unused vignettes #955

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Remove old and unused vignettes #955

merged 1 commit into from
Jun 16, 2022

Conversation

IndrajeetPatil
Copy link
Collaborator

Closes #953

For future reference:

If you want to check these out, do-
git checkout v1.0.0

@IndrajeetPatil
Remove old and unused vignettes
eabeed0 
Closes #953

For future reference:

If you want to check these out, do-
`git checkout v1.0.0`
@IndrajeetPatil IndrajeetPatil marked this pull request as ready for review June 16, 2022 12:11
@IndrajeetPatil
Copy link
Collaborator Author

Okay, pkgdown build is succeeding now.

@lorenzwalthert lorenzwalthert merged commit 0731438 into r-lib:main Jun 16, 2022
@IndrajeetPatil IndrajeetPatil deleted the 953_remove_old_vignettes branch June 16, 2022 12:27
@lorenzwalthert
Copy link
Collaborator

Thanks. Also please add a NEWS.md entry next time 😊

@IndrajeetPatil
Copy link
Collaborator Author

Ah, sorry, didn't realize that these were user-facing; I thought you were already skipping them on CRAN.

I can update NEWS in the PR for #954.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 3178326 is merged into main:

  •   :ballot_box_with_check:cache_applying: 25ms -> 24.8ms [-3.24%, +1.46%]
  •   :ballot_box_with_check:cache_recording: 1.06s -> 1.07s [-1.2%, +3.09%]
  •   :ballot_box_with_check:without_cache: 2.94s -> 2.91s [-3.1%, +1.38%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pgkdown page needs to be fixed
2 participants
@IndrajeetPatil @lorenzwalthert