Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Left-alignment with more than 2 columns #945

Merged
merged 1 commit into from
May 18, 2022
Merged

Left-alignment with more than 2 columns #945

merged 1 commit into from
May 18, 2022

Conversation

lorenzwalthert
Copy link
Collaborator

@lorenzwalthert lorenzwalthert commented May 17, 2022

Closes #943. Also improve on #258.

@codecov-commenter
Copy link

Codecov Report

Merging #945 (a546e90) into main (1bda68a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #945   +/-   ##
=======================================
  Coverage   89.80%   89.81%           
=======================================
  Files          47       47           
  Lines        2610     2611    +1     
=======================================
+ Hits         2344     2345    +1     
  Misses        266      266           
Impacted Files Coverage Δ
R/detect-alignment.R 97.72% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bda68a...a546e90. Read the comment docs.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 535fcbc is merged into main:

  •   :ballot_box_with_check:cache_applying: 25.3ms -> 25.5ms [-0.03%, +1.32%]
  •   :rocket:cache_recording: 1.09s -> 1.08s [-0.99%, -0.25%]
  •   :ballot_box_with_check:without_cache: 2.95s -> 2.94s [-0.37%, +0.13%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@lorenzwalthert lorenzwalthert merged commit 459a03f into main May 18, 2022
@lorenzwalthert lorenzwalthert deleted the issue-943 branch May 18, 2022 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alignment detection not working for more than 2 columns
2 participants