Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rules that create tokens must be stylerignore aware #891

Merged
merged 8 commits into from
Dec 29, 2021

Conversation

lorenzwalthert
Copy link
Collaborator

@lorenzwalthert lorenzwalthert commented Dec 29, 2021

Closes #890.

@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2021

Codecov Report

Merging #891 (bf5c5f6) into main (7175da0) will decrease coverage by 0.00%.
The diff coverage is 91.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #891      +/-   ##
==========================================
- Coverage   89.67%   89.66%   -0.01%     
==========================================
  Files          47       47              
  Lines        2518     2536      +18     
==========================================
+ Hits         2258     2274      +16     
- Misses        260      262       +2     
Impacted Files Coverage Δ
R/relevel.R 46.37% <60.00%> (+0.22%) ⬆️
R/detect-alignment-utils.R 90.90% <100.00%> (+0.28%) ⬆️
R/rules-tokens.R 100.00% <100.00%> (ø)
R/token-create.R 96.07% <100.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7175da0...bf5c5f6. Read the comment docs.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 9397144 is merged into main:

  •   :ballot_box_with_check:cache_applying: 28.6ms -> 31.4ms [-4.36%, +23.64%]
  •   :ballot_box_with_check:cache_recording: 1.13s -> 1.01s [-24.21%, +3.94%]
  •   :ballot_box_with_check:without_cache: 2.7s -> 2.69s [-2.46%, +1.5%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 0785237 is merged into main:

  •   :ballot_box_with_check:cache_applying: 27.8ms -> 27.9ms [-0.48%, +0.95%]
  •   :ballot_box_with_check:cache_recording: 996ms -> 998ms [-0.56%, +0.85%]
  •   :ballot_box_with_check:without_cache: 2.64s -> 2.65s [-0.46%, +0.97%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if ab025de is merged into main:

  •   :ballot_box_with_check:cache_applying: 28.6ms -> 28.6ms [-1.62%, +1.52%]
  •   :ballot_box_with_check:cache_recording: 1.01s -> 1.01s [-0.76%, +1.18%]
  •   :ballot_box_with_check:without_cache: 2.7s -> 2.71s [-0.74%, +1.45%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if a12c99c is merged into main:

  •   :ballot_box_with_check:cache_applying: 31.2ms -> 31ms [-2.59%, +1.19%]
  •   :ballot_box_with_check:cache_recording: 1.1s -> 1.1s [-2.19%, +1.65%]
  •   :ballot_box_with_check:without_cache: 2.89s -> 2.88s [-2.24%, +1.24%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stylerignore not working for braced pipe expression
2 participants