Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix calculation of temp_dir in delete_if_cache_directory() #1126

Merged
merged 1 commit into from
Jun 1, 2023
Merged

fix calculation of temp_dir in delete_if_cache_directory() #1126

merged 1 commit into from
Jun 1, 2023

Conversation

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
Copy link
Contributor

close #1125

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

This is how benchmark results would change (along with a 95% confidence interval in relative change) if aeaa1fa is merged into main:

Further explanation regarding interpretation and methodology can be found in the documentation.

@lorenzwalthert lorenzwalthert merged commit e8836fd into r-lib:main Jun 1, 2023
@lorenzwalthert
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorenzwalthert lorenzwalthert lorenzwalthert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

temp_dir in delete_if_cache_directory() does not work as intended, throws cryptic warnings
2 participants
@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q @lorenzwalthert