Evaluate print in evaluation environment #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cderv
reviewed
Jul 4, 2024
There was a problem hiding this comment.
This creates R CMD CHECK failure for knitr when building vignette
https://github.com/yihui/knitr/actions/runs/9791626150/job/27035802276
* creating vignettes ... ERROR
Error: --- re-building ‘docco-classic.Rmd’ using docco_classic_notangle
Quitting from lines 13-20 [setup] (docco-classic.Rmd)
Error: Error: processing vignette 'docco-classic.Rmd' failed with diagnostics:
object 'visible' not found
--- failed re-building ‘docco-classic.Rmd’
So we need to look to check this
lionel-
approved these changes
Jul 8, 2024
Comment on lines
+49
to
+51
| print_env <- new.env(parent = envir) | ||
| print_env$value <- value | ||
| evalq(print(value), envir = print_env) |
Co-authored-by: Lionel Henry <lionel.hry@gmail.com>
|
Ah the problem is that knitr does this: |
|
I made yihui/knitr#2353 so we can eventually drop this extra code. |
cderv
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #192
This turned out to be rather straightforward to implement after all the refactoring, and while it's unlikely to affect much user code, I think the changes to the tests demonstrates its utility.