Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add useful development dependencies #2411

Merged
merged 5 commits into from
Mar 2, 2022
Merged

Add useful development dependencies #2411

merged 5 commits into from
Mar 2, 2022

Conversation

hadley
Copy link
Member

@hadley hadley commented Mar 1, 2022

Fixes #2388

Along the way I did:

  • use_tidy_description()
  • use_latest_dependencies(TRUE, "CRAN")
  • Moved packages from suggests to imports without changing which packages will actually be installed by carefully consulting pak::local_deps_explain().

…alled

This avoids the R CMD check warning when importing over 20 packages by gaming the system.

callr needed by pkgbuild + pkgdown + rcmdcheck + testthat
httr needed by usethis + pkgdown
lifecycle needed by usethis + miniUI + pkgdown + testthat
rstudioapi needed by usethis + pkgload + roxygen2 + testthat
@hadley hadley requested a review from jennybc March 1, 2022 17:02
Copy link
Member

@jennybc jennybc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Moved packages from suggests to imports

Is this motivated by concerns around the total number of Imports?

@hadley
Copy link
Member Author

hadley commented Mar 2, 2022

Yeah, just to avoid the R CMD check note

@hadley hadley merged commit 575ae4e into main Mar 2, 2022
@hadley hadley deleted the dev-deps branch March 2, 2022 18:40
@jennybc jennybc mentioned this pull request Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add other useful development packages to imports
2 participants