macOS: Fix HID crashing regression #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tresf
force-pushed
the
hid-fix
branch
2 times, most recently
from
104e830
to
e279f23
Compare
|
Somehow this PR was accidentally missed for the 2.2.4 release. I've rebased this on master so that we can test viability for an emergency 2.2.4+2 release. |
|
@lite1979 tested this code and has approved it for merge. Merging. We'll bump the macOS downloads to 2.2.4+2. Sorry for any confusion that this causes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QZ Tray 2.2.3 reintroduced a regression similar to #137 likely introduced with #1177.
Background
This patch is based solely off of the (at time of writing this) unmerged:
It adds some sane same-thread handling to otherwise unwieldy HID calls from our software.
Closes #137
Closes #1265