Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PIN must be specified in hex?!? #6

Open
rovo89 opened this issue May 29, 2023 · 1 comment
Open

PIN must be specified in hex?!? #6

rovo89 opened this issue May 29, 2023 · 1 comment

Comments

@rovo89
Copy link
Contributor

rovo89 commented May 29, 2023

ReadLogEntryStream() and other functions require the device PIN. I would have expected that a PIN like 9999 would be specified as integer 9999 or as string "9999". But the current implementation of NewPin() expects a hex string like "270F" instead. Is this intended?
rovo89 added a commit to rovo89/go-nuki that referenced this issue Jun 2, 2023
@rovo89
Interpret PIN as decimal string (fixes qvest-digital#6)
60ff647 
Previously it was expected as hex string, but if a script asks a user to
enter their PIN, "1234" is probably more natural to type than "04D2".
@sschum
Copy link
Collaborator

sschum commented Jun 6, 2023 •
edited
Loading

Maybe we only had the pin "0000" which is in both implementations (yours and ours) "0000" 😇 And that is why we have not noticed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rovo89 @sschum