Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make_timeline ignores actors with empty names #5943

Open
quisquous opened this issue Nov 22, 2023 · 2 comments
Open

make_timeline ignores actors with empty names #5943

quisquous opened this issue Nov 22, 2023 · 2 comments
Labels
bug

Comments

@quisquous
Copy link
Owner

Aloalo Island_TheAncientForum_20231122_125308.000_4m.log

I haven't looked into cause yet, but it appears that ts-node util/logtools/make_timeline.ts -f Aloalo\ Island_TheAncientForum_20231122_125308.000_4m.log -lf 1 -la misses both 8BA6 and 8BAD abilities in the table and the timeline log.
@quisquous quisquous added the bug label Nov 22, 2023
@quisquous
Copy link
Owner Author

cc @JLGarber FYI

@JLGarber
Copy link
Collaborator

I'll have a look at it after I handle the updates to network seal lines. Thanks for the ping, I haven't been reviewing issues much these days.

This was referenced Dec 25, 2023
Closed
Merged
wexxlee added a commit to OverlayPlugin/cactbot that referenced this issue Dec 28, 2023
@wexxlee
util: improve empty-name actor logic in make_timeline (#19)
58e9a9a 
Closes #18.
(ref discussion in quisquous#5943).

Instead of ignoring all abilities used by combatants with an empty name
field, `make_timeilne` will now include entries in the timeline and the
timeline ability table if the empty-name combatant uses a named ability.
github-actions bot pushed a commit to OverlayPlugin/cactbot that referenced this issue Dec 28, 2023
gh-pages build: util: improve empty-name actor logic in make_timeline (…
0b4a455 
…#19)

Closes #18.
(ref discussion in quisquous#5943).

Instead of ignoring all abilities used by combatants with an empty name
field, `make_timeilne` will now include entries in the timeline and the
timeline ability table if the empty-name combatant uses a named ability. 58e9a9a
SiliconExarch pushed a commit to SiliconExarch/cactbot that referenced this issue Jan 5, 2024
@wexxlee @SiliconExarch
util: improve empty-name actor logic in make_timeline (quisquous#19)
ede6ba4 
Closes quisquous#18.
(ref discussion in quisquous#5943).

Instead of ignoring all abilities used by combatants with an empty name
field, `make_timeilne` will now include entries in the timeline and the
timeline ability table if the empty-name combatant uses a named ability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@quisquous @JLGarber