Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send path validation responses to the correct remote #1746

Merged
merged 6 commits into from
Jan 25, 2024
Merged

Conversation

Ralith
Copy link
Collaborator

@Ralith Ralith commented Jan 21, 2024

We previously always sent these on the active path, which undermines a peer's validation of the return direction of a candidate new path.

Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up!

quinn-proto/src/connection/mod.rs Show resolved Hide resolved
quinn-proto/src/connection/mod.rs Outdated Show resolved Hide resolved
quinn-proto/src/connection/mod.rs Outdated Show resolved Hide resolved
quinn-proto/src/connection/mod.rs Outdated Show resolved Hide resolved
quinn-proto/src/connection/mod.rs Outdated Show resolved Hide resolved
@Ralith Ralith force-pushed the fix-path-validation branch 2 times, most recently from 7e5714b to 57f0bad Compare January 23, 2024 03:09
quinn-proto/src/connection/mod.rs Show resolved Hide resolved
quinn-proto/src/connection/mod.rs Outdated Show resolved Hide resolved
@Ralith Ralith force-pushed the fix-path-validation branch 3 times, most recently from c1ff4a6 to 3eeb984 Compare January 24, 2024 01:25
quinn-proto/src/connection/paths.rs Outdated Show resolved Hide resolved
quinn-proto/src/connection/paths.rs Show resolved Hide resolved
quinn-proto/src/connection/mod.rs Show resolved Hide resolved
@Ralith Ralith force-pushed the fix-path-validation branch 2 times, most recently from 8e5a09d to 400f729 Compare January 24, 2024 22:29
@djc djc merged commit 1c7c460 into main Jan 25, 2024
8 checks passed
@djc djc deleted the fix-path-validation branch January 25, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants