-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSO config: view/edit config and disable role assigning for SSO mapped users #4070
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4070 +/- ##
==========================================
- Coverage 38.47% 38.33% -0.14%
==========================================
Files 717 720 +3
Lines 33025 33143 +118
Branches 4665 4879 +214
==========================================
Hits 12706 12706
+ Misses 19695 19289 -406
- Partials 624 1148 +524
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
that can be done in a follow-up PR, it's even ok if we merge it after the release (or after RC at least) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks okay.
i think you should also add some conditional logic to role editing menu: a) disable/remove "set as default" option; and b) remove "delete" option for mapped roles (do we have enough data in gql for this?)
what you've got seems sufficient i think |
Co-authored-by: Alexei Mochalov <nl_0@quiltdata.io>
Thanks. Done.
No. @sir-sigurd can we add this to role struct: role is mapped, so user can't delete it? |
I'm not sure (that's the best time to work on it right now|what's the best way to implement it)
so it looks like we need to add multiple fields and since it looks like you want to display a reason why specific action is forbidden that fields should return something more that just a bool |
Co-authored-by: Alexei Mochalov <nl_0@quiltdata.io>
Co-authored-by: Alexei Mochalov <nl_0@quiltdata.io>
…to role-mapping-frontend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the changes look good. pls update the PR description to reflect the changes.
role.isDefaultRoleSettingDisabled
user.isRoleAssignmentDisabled