-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
View and edit SSO config #4072
View and edit SSO config #4072
Conversation
fiskus
commented
Aug 8, 2024
•
edited
Loading
edited
- Check if there is SSO config (without fetching it) and show "individual assignment" icon button
- Show YAML editor in popup dialog. Editor is heavy, but it is lazy loaded
- Changelog entry (skip if change is not significant to end users, e.g. docs only)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## role-mapping-frontend #4072 +/- ##
=========================================================
- Coverage 38.43% 38.33% -0.10%
=========================================================
Files 717 718 +1
Lines 33060 33045 -15
Branches 4859 4878 +19
=========================================================
- Hits 12706 12669 -37
- Misses 19207 19228 +21
- Partials 1147 1148 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok, tho i wouldn't use a separate partial query.
let's merge this into the upstream PR anyways and finish it off there,
since i feel quite confident we're shipping this one too.
|
||
function TextField({ errors, input, meta }: TextFieldProps) { | ||
// TODO: lint yaml | ||
const errorMessage = meta.submitFailed && errors[meta.error] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this handle submit errors properly? i vaguely remember i had some confusion with form errors vs submit errors -- they were under different fields and i had to check both these fields, but i don't remember which api this was, maybe form-level 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for field-level errors. And I just don't show the validation error when form hadn't submitted.
This piece of code is the same as in other TextField across app.
On the other hand, form-specific error. There I made a "shortcut" and since this form is one-field, I show the error from API directly, not from final-form.