Make PhysicalKey a facade above s3://, file:// and (TODO) sharepoint://

[fiskus]

Description

TODO:

• Pass location to PhysicalKey instead of bucket, path, version_id
• location is a S3ObjectLocation (s3://) or LocalLocation (file://)
• Tests succeed
• location can be SharePointLocation (sharepoint://)
• Tests succeed

---

• Unit tests
• Automated tests (e.g. Preflight)
• Confirm that this change meets security best practices and does not violate the security model
• Documentation
  • Python: Run build.py for new docstrings
  • JavaScript: basic explanation and screenshot of new features
  • Markdown somewhere in docs/**/*.md that explains the feature to end users (said .md files should be linked from SUMMARY.md so they appear on https://docs.quiltdata.com)
  • Markdown docs for developers
• Changelog entry (skip if change is not significant to end users, e.g. docs only)

[codecov]

Codecov Report

Attention: Patch coverage is 92.25806% with 12 lines in your changes missing coverage. Please review.

Project coverage is 37.29%. Comparing base (68bfbc3) to head (676d737).
Report is 8 commits behind head on master.

Files	Patch %	Lines
api/python/quilt3/util.py	90.55%	12 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4064      +/-   ##
==========================================
- Coverage   38.47%   37.29%   -1.18%     
==========================================
  Files         717      711       -6     
  Lines       33023    32413     -610     
  Branches     4837     4837              
==========================================
- Hits        12704    12090     -614     
+ Misses      19695    19176     -519     
- Partials      624     1147     +523     

Flag	Coverage Δ
api-python	90.66% <92.25%> (-0.09%)	⬇️
catalog	11.51% <ø> (ø)
lambda	86.10% <ø> (-1.86%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sir-sigurd]

@fiskus
you may want to have a look on my previous attempt to split S3 and local physical keys
#1982

[drernie]

I wonder... should we instead just:

1. Use the OpenDAL Python bindings for our physical keys
2. Use the Rust SDK to add SharePoint support to OpenDAL