-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change CI trigger to just "push". Remove "venv". #3864
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3864 +/- ##
===========================================
+ Coverage 35.40% 89.31% +53.90%
===========================================
Files 709 79 -630
Lines 31254 9995 -21259
Branches 4681 0 -4681
===========================================
- Hits 11066 8927 -2139
+ Misses 19032 1068 -17964
+ Partials 1156 0 -1156
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
These seem to be left over from CircleCI. Let's clean them up: - Any pull request involves pushing to some branch, so `push` is sufficient - Pushing a tag also triggers the workflow, so no need to handle those differently - CircleCI required virtual environments to be set up, but that's not the case anymore, so there's no `./venv`
tags: | ||
- "*" | ||
pull_request: | ||
merge_group: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- master | ||
tags: | ||
- "*" | ||
pull_request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure it's really needed, but #3001
All of that seems to be left over from Circle CI.