Airmail 20240628 #5178
Closed
Airmail 20240628 #5178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- to deal with the \0 sstable ordering bug - to include @PSeitz version of the columnar multivalue sparse index fix.
The piece that estimates whether the next request is likely to fail is extremely simplistic for the moment. It simply counter the number of errors (not taking in account successes) that happened in a given time window. The reason is that for the moment, we want to use it for persist requests when the WAL is full. On airmail, the aggressive retry logic of the client was causing a massive grpc storm on the faulty indexer node, taking all of its CPU and preventing it from getting out of that state. In this case, the error estimation logic is very simple, a full WAL guarantees that no further persist request will be successful for a little while.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.