-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connect shard throughput #5151
Open
fulmicoton
wants to merge
2
commits into
main
Choose a base branch
from
connect-shard-throughput
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Connect shard throughput #5151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2a7d6ea
to
038a316
Compare
038a316
to
edd6787
Compare
fulmicoton
commented
Jul 1, 2024
a2686ca
to
a43c7a7
Compare
a43c7a7
to
76cc3d9
Compare
trinity-1686a
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some lints are firing, otherwise lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on simian with a pathologic workload:
On the left, without any per-shard weighting.
On the right, with per-shard weighting.
indexing throughput
![image](https://private-user-images.githubusercontent.com/1021506/342264859-9eed910c-c1bd-41c8-8d02-e32933f84adf.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk5NjIwMDUsIm5iZiI6MTcxOTk2MTcwNSwicGF0aCI6Ii8xMDIxNTA2LzM0MjI2NDg1OS05ZWVkOTEwYy1jMWJkLTQxYzgtOGQwMi1lMzI5MzNmODRhZGYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcwMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MDJUMjMwODI1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MjMyNGNiNjk2MjE0Y2RhOWMyMjg1NTAzZmU5MmQ5ZWM2YWI4NDc2YmJkNGViMzQ2OTM5N2EyZDk4OWJhNDc0NiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.0hyPP-KPOk_c7GjpL7f01YUQJlFdJCgZaeSF2gmiRag)
cpu usage
![image](https://private-user-images.githubusercontent.com/1021506/342272166-6de1661c-4390-4348-9675-f82ff6f6e912.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk5NjIwMDUsIm5iZiI6MTcxOTk2MTcwNSwicGF0aCI6Ii8xMDIxNTA2LzM0MjI3MjE2Ni02ZGUxNjYxYy00MzkwLTQzNDgtOTY3NS1mODJmZjZmNmU5MTIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcwMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MDJUMjMwODI1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ODI5YTY5NzhjZjgyMDI4MzdmMDJhMzNlODQ1ZWQ0ODQ1MWIxZDdjNDRmMTgyMmY4YmIwYTJmNjY3MTUxZWRlNSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.viS-VdtEjs_-ZqjKKZOwyc-PPrX0YLtkw9R8koi3W0k)