Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize String.fromCharCode and String.fromCodePoint #391

Merged
merged 1 commit into from
Apr 21, 2024
Merged

Optimize String.fromCharCode and String.fromCodePoint #391

merged 1 commit into from
Apr 21, 2024

Conversation

chqrlie
Copy link
Collaborator

@chqrlie chqrlie commented Apr 20, 2024 •
edited
Loading

  • test for common case: single integer argument and create string directly

This causes a small reduction of the test262 test time. (2%)

@chqrlie
Optimize String.fromCharCode and String.fromCodePoint
e144710 
- test for common case: single integer argument and create string directly
saghul
saghul approved these changes Apr 20, 2024
View reviewed changes
Copy link
Contributor

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@chqrlie chqrlie merged commit a77873d into quickjs-ng:master Apr 21, 2024
47 checks passed
@chqrlie chqrlie deleted the optimize-string-fromcharcode branch April 21, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@saghul saghul saghul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chqrlie @bnoordhuis @saghul