-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve dump option support #344
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments!
This needs a rebase now that you did the split and the other stuff can be merged. |
Yes, I am aware of this and it would have been difficult to avoid it. |
Yes you can do that. Make sure to use --force then. |
fc3b2bd
to
43a7fc3
Compare
- DUMP_XXX defined as nothing or 0 produces unconditional output - DUMP_XXX defined as a bitmask produces conditional output based on command line option -d<bitmask> - add `JS_SetDumpFlags()` to select active dump options - accept -d[<hex mask>] and --dump[=<hex mask>] to specify active dump options, generalize command line option handling - improve DUMP_READ_OBJECT output, fix indentation issue
43a7fc3
to
1692198
Compare
@bnoordhuis do you have any remarks? can I proceed and merge this? |
JS_SetDumpFlags()
to select active dump optionsDUMP_XXX
output dynamically selectableDUMP_READ_OBJECT
output, fix indentation issue