Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retain function source code in serialized bytecode #218

Merged
merged 3 commits into from
Dec 16, 2023
Merged

Retain function source code in serialized bytecode #218

merged 3 commits into from
Dec 16, 2023

Conversation

bnoordhuis
Copy link
Contributor

@bnoordhuis bnoordhuis commented Dec 14, 2023 •
edited
Loading

Fixes: #217

I wanted to add a regression test but... hoops added, but yes, hoops

saghul
saghul approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a cast it seems!

@saghul
Copy link
Contributor

saghul commented Dec 15, 2023

Maybe I can add a test with the fib example. I'll explore.

@bnoordhuis
Copy link
Contributor Author

Ha, -funsigned-char strikes again! I'll fix that and see if I can add a test of sorts.

@bnoordhuis
Retain function source code in serialized bytecode
0630538 
Also fix a small memory leak in the generated output from `qjsc -e`.

Fixes: quickjs-ng#217
@bnoordhuis bnoordhuis merged commit 5cbf872 into quickjs-ng:master Dec 16, 2023
31 checks passed
@bnoordhuis bnoordhuis deleted the fix217 branch December 16, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saghul saghul saghul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Store source in bytecode
2 participants
@bnoordhuis @saghul