-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set default visibility to hidden and export the public API #140
Conversation
@bnoordhuis WDYT? The use of many inlines in the header file make it required to export "internal" simbols... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but it would be nice if all function parameters got lined up again. :-)
Sure thing, I wouldn't be able to sleep at night otherwise :-P Just wanted some feedback on the weird stuff like the pragma to be able to use cutils stuff... Looks like I'll need to figure out why extension module loading broke 😅 That's for tomorrow night! |
You could add a JS_EXTERN_PRIVATE define that's just like JS_EXTERN except to indicate it's not for public use. (Maybe not the greatest name because private_extern linkage is a thing but oh well.) |
ccfa1f9
to
fa7a5c0
Compare
I think I figured it out, check the fixup commit. |
Ah lol, I did not see your commits! 😅 |
No description provided.