Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Enable macos desktop #188

Merged
merged 73 commits into from
Aug 2, 2024
Merged

feat: Enable macos desktop #188

merged 73 commits into from
Aug 2, 2024

Conversation

ymauray
Copy link
Member

@ymauray ymauray commented Jul 11, 2024 •
edited

Description

This pull request enables macos desktop for quickgui.

This is still early work, so they're might be some edges cases that will need investigation.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have performed a self-review of my code
  • I have tested my code in common scenarios and confirmed there are no regressions
  • I have added comments to my code, particularly in hard-to-understand sections
  • I have updated and committed pubspec.yaml and pubspec.lock
    • flutter pub get

What is has been tested on

  • mac book air M2, default macos terminal

What works

  • Getting the list of available OSes and their versions from quickget
  • Starting the download, and monitoring its progression
  • Listing availables VMs
  • Starting and stopping a VM through quickemu
  • Connecting to a VM via SSH using the default macos terminal
  • Partially or completely deleting a VM

What has not been tested

  • Downloading and running any distro which does not have "ubuntu" in its name

What does not work

  • Packaging a dmg file. I need to look into that.

@ymauray
feat: macos desktop app on Apple silicon, initial config [wip]
6ad3bc4
@ymauray
feat: macos desktop app on Apple silicon, initial config [wip]
fea175c
@ymauray
Merge branch 'macos_desktop' of https://github.com/quickemu-project/q…
c89ed06 
…uickgui into macos_desktop
@ymauray
fix: use "super.key"
8d0a5da
@ymauray
chore: .vscode settings
07a29cb
@ymauray
fix: more use of "super.key"
703094c
@ymauray
chore: formating
bb79304
@ymauray
feat: misc macos settings.
3997023
@ymauray
feat: set window size
02c3a90
@ymauray
fix: desktop notification not (yet?) supported on macos
97f7832
@ymauray
Merge branch 'main' into macos_desktop
83ca25a
@ymauray
Merge branch 'main' into macos_desktop
cd9657f
@ymauray
Merge branch 'main' into macos_desktop
7257157
@ymauray
Merge branch 'main' into macos_desktop
c2ef833
@ymauray
Merge branch 'main' into macos_desktop
2d00e31
@ymauray
fix: don't use a private variable for $version
0ac0ea0
@ymauray
Merge branch 'main' into macos_desktop
69a32d3
@ymauray
fix : comment
21ea78b
@ymauray
feat: macos desktop app on Apple silicon, initial config [wip]
a6acc90
@ymauray
fix: use "super.key"
8b0b3ab
@ymauray
chore: .vscode settings
f79524d
@ymauray
fix: more use of "super.key"
2aaafe9
@ymauray
chore: formating
1b45349
@ymauray
feat: misc macos settings.
429584c
@ymauray
feat: set window size
7b8c384
@ymauray
fix: desktop notification not (yet?) supported on macos
f7985e2
@ymauray
fix: don't use a private variable for $version
56dc59e
@ymauray
fix : comment
b73bded
@ymauray
feat: in debug mode, throw an exception is a message is not translated
bedcbca
@ymauray
chore: localizations
1e41981
@ymauray
feat: misc macos settings.
3c0609e
@ymauray
feat: set window size
0da47a7
@ymauray
fix: desktop notification not (yet?) supported on macos
ace4914
@ymauray
fix: don't use a private variable for $version
a28fb8b
@ymauray
fix : comment
9e7eeee
@ymauray
feat: in debug mode, throw an exception is a message is not translated
57c5c76
@ymauray
chore: localizations
b5021c9
@ymauray
feat: detect and use the Terminal app to connect via SSH
c833b36
@ymauray
fix: don't try to connect via SSH with empty username
c85890f
@ymauray
feat: macos desktop app on Apple silicon, initial config [wip]
b16a19d
@ymauray
feat: misc macos settings.
7e7abe2
@ymauray
feat: set window size
921a299
@ymauray
fix : comment
3248e3e
@ymauray
feat: macos desktop app on Apple silicon, initial config [wip]
a679db6
@ymauray
feat: misc macos settings.
1e05d6b
@ymauray
Merge branch 'macos_desktop' of https://github.com/quickemu-project/q…
1d48aa2 
…uickgui into macos_desktop
@ymauray ymauray changed the title Enable macos desktop feat: Enable macos desktop Jul 11, 2024
flexiondotorg
flexiondotorg reviewed Jul 14, 2024
View reviewed changes
Copy link
Member

@flexiondotorg flexiondotorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll find time to build/test this soon 👍

macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_1024.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this icon be a Quickemu/gui logo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, yes it should !

macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_128.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this icon be a Quickemu/gui logo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, yes it should !

macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_16.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this icon be a Quickemu/gui logo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, yes it should !

macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_256.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this icon be a Quickemu/gui logo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, yes it should !

macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_32.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this icon be a Quickemu/gui logo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, yes it should !

macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_512.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this icon be a Quickemu/gui logo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, yes it should !

macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_64.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this icon be a Quickemu/gui logo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, yes it should !

@ymauray
Copy link
Member Author

ymauray commented Jul 15, 2024

I fixed the icons, hopefully.

ymauray
ymauray commented Jul 15, 2024
View reviewed changes
Copy link
Member Author

@ymauray ymauray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to do the trick for building the .dmg

@ymauray ymauray mentioned this pull request Jul 25, 2024
Open
@flexiondotorg flexiondotorg merged commit 62faac7 into main Aug 2, 2024
4 checks passed
@flexiondotorg flexiondotorg deleted the macos_desktop branch August 2, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flexiondotorg flexiondotorg flexiondotorg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ymauray @flexiondotorg