Added automatic version fetching for ubuntu #821

Jai-JAP · 2023-10-24T10:12:40Z

Fetch ubuntu versions directly from https://api.launchpad.net/devel/ubuntu/series (desktop flavors) and http://releases.ubuntu.com/streams/v1/com.ubuntu.releases:ubuntu-server.json (Server)
Remove obsolete releases {daily-canary, jammy-daily}
Format documents with shfmt

philclifford · 2023-10-24T15:25:18Z

Excellent!

One tweak though - jammy-daily is not quite obsolete :

https://cdimage.ubuntu.com/jammy/daily-live/current/
https://iso.qa.ubuntu.com/qatracker/milestones/429/builds

Jai-JAP · 2023-10-24T16:10:16Z

Excellent!

One tweak though - jammy-daily is not quite obsolete :

https://cdimage.ubuntu.com/jammy/daily-live/current/
https://iso.qa.ubuntu.com/qatracker/milestones/429/builds

I'll fix that soon.

Jai-JAP · 2023-10-24T18:08:23Z

jammy-daily should be back working now

philclifford · 2023-10-24T23:46:26Z

Thanks

flexiondotorg

I can not accept pull requests that change the indentation project wide.

Jai-JAP · 2023-11-09T13:49:38Z

I can not accept pull requests that change the indentation project wide.

I will fix that soon. Will reverting to indent_size 2 be sufficient?

flexiondotorg · 2023-11-10T10:29:18Z

This patch is massive:

Please refactor this pull request to only provide the changes to add automatic version fetching for Ubuntu and remove all whitespace-related changes.

Jai-JAP · 2023-11-10T19:22:31Z

@flexiondotorg ig the changes you requested are resolved.

philclifford

The purely-whitespace changes would be better dealt with in another (possibly existing) PR. (But at least now they are restricted to a couple of functions. - this is not a show-stopper for me but ...)

The results do not correctly align with the available releases so there is either a flaw in the logic or in what the api presents.
Some examples below (./quickget is the PR version) showing missing 23.10 interims , missing jammy-daily options and non-existent early releases.

$
$quickget ubuntu-unity
ERROR! You must specify a release.
 - Releases: 23.04 23.10 daily-live daily-canary
$./quickget ubuntu-unity
ERROR! You must specify a release.
 - Releases: 23.04 daily-live
$quickget xubuntu
ERROR! You must specify a release.
 - Releases: 16.04 18.04 20.04 22.04 23.04 23.10 jammy-daily daily-live daily-canary daily-legacy                                                                        
$./quickget xubuntu
ERROR! You must specify a release.
 - Releases: 14.04 16.04 18.04 20.04 22.04 23.04 23.10 daily-live daily-legacy jammy-daily                                
$quickget ubuntucinnamon
ERROR! You must specify a release.
 - Releases: 23.04 23.10 daily-live daily-canary
$./quickget ubuntucinnamon
ERROR! You must specify a release.
 - Releases: 23.04 daily-live
$quickget ubuntu-server
ERROR! You must specify a release.
 - Releases: 18.04 20.04 22.04 23.04 23.10 daily-live
$./quickget ubuntu-server
ERROR! You must specify a release.
 - Releases: 18.04 20.04 22.04 23.04 23.10 daily-live
$quickget ubuntu
ERROR! You must specify a release.
 - Releases: 14.04 16.04 18.04 20.04 22.04 23.04 23.10 jammy-daily daily-live daily-canary daily-legacy    
$./quickget ubuntu
ERROR! You must specify a release.
 - Releases: 14.04 16.04 18.04 20.04 22.04 23.04 23.10 daily-live daily-legacy                                                                     
$quickget ubuntu-mate
ERROR! You must specify a release.
 - Releases: 16.04 18.04 20.04 22.04 23.04 23.10 jammy-daily daily-live daily-canary daily-legacy                                                                        
$./quickget ubuntu-mate
ERROR! You must specify a release.
 - Releases: 14.04 16.04 18.04 20.04 22.04 23.04 23.10 daily-live daily-legacy jammy-daily

philclifford · 2023-11-12T18:38:43Z

quickget

@@ -1659,13 +1638,13 @@ function get_manjaro() {
    [[ ${RELEASE} != "sway" ]] && MANIFEST="$(wget -qO- https://gitlab.manjaro.org/web/iso-info/-/raw/master/file-info.json)"

    [[ ${EDITION} == "minimal" && ${TYPE} != "sway" ]] && EDITION=".minimal" || EDITION=""
-
-    if [[ ${RELEASE} != "sway" ]]; then 
+


Should not be changing vanillaos or other non-ubuntu functions in this PR

Should not be changing vanillaos or other non-ubuntu functions in this PR

I didn't make any manual changes here. Maybe editorconfig automatically removing trailing whitespaces.

Jai-JAP · 2023-11-13T12:45:14Z

The results do not correctly align with the available releases so there is either a flaw in the logic or in what the api presents.

I'll fix that soon. Caught the cause of it.

Jai-JAP · 2023-11-14T15:42:17Z

@philclifford Everything should be working fine now. Can you test again?

philclifford · 2023-11-14T18:19:07Z

@philclifford Everything should be working fine now. Can you test again?

Looks to be sorted, thanks @Jai-JAP. My local version of your PR may be missing full edubuntu support from the fix in #819, but I believe that won't be an issue. The following seems to be consistent with current reality, and hopefully the use of the api now means we will have a smoother maintenance flow in future.

for os in edubuntu kubuntu lubuntu ubuntu ubuntu-budgie ubuntucinnamon ubuntukylin ubuntu-mate ubuntu-server ubuntustudio ubuntu-unity xubuntu; do echo $os ; echo Upstream ;quickget $os;echo PR; ./quickget $os; done |grep -v ERROR
edubuntu
Upstream
 - Releases: 23.04 23.10 daily-live daily-canary
PR
[ Error: not a supported os ... probably missing #819 ]

kubuntu
Upstream
 - Releases: 16.04 18.04 20.04 22.04 23.04 23.10 jammy-daily daily-live daily-canary daily-legacy                                                                        
PR
 - Releases: 16.04 18.04 20.04 22.04 23.04 23.10 daily-live daily-legacy jammy-daily                                
lubuntu
Upstream
 - Releases: 16.04 18.04 20.04 22.04 23.04 23.10 jammy-daily daily-live daily-canary daily-legacy                                                                        
PR
 - Releases: 16.04 18.04 20.04 22.04 23.04 23.10 daily-live daily-legacy jammy-daily                                
ubuntu
Upstream
 - Releases: 14.04 16.04 18.04 20.04 22.04 23.04 23.10 jammy-daily daily-live daily-canary daily-legacy                                                                        
PR
 - Releases: 14.04 16.04 18.04 20.04 22.04 23.04 23.10 daily-live daily-legacy                                
ubuntu-budgie
Upstream
 - Releases: 18.04 20.04 22.04 23.04 23.10 jammy-daily daily-live daily-canary daily-legacy                                                                        
PR
 - Releases: 18.04 20.04 22.04 23.04 23.10 daily-live daily-legacy jammy-daily                                
ubuntucinnamon
Upstream
 - Releases: 23.04 23.10 daily-live daily-canary
PR
 - Releases: 23.04 23.10 daily-live
ubuntukylin
Upstream
 - Releases: 16.04 18.04 20.04 22.04 23.04 23.10 jammy-daily daily-live daily-canary daily-legacy                                                                        
PR
 - Releases: 16.04 18.04 20.04 22.04 23.04 23.10 daily-live daily-legacy jammy-daily                                
ubuntu-mate
Upstream
 - Releases: 16.04 18.04 20.04 22.04 23.04 23.10 jammy-daily daily-live daily-canary daily-legacy                                                                        
PR
 - Releases: 16.04 18.04 20.04 22.04 23.04 23.10 daily-live daily-legacy jammy-daily                                
ubuntu-server
Upstream
 - Releases: 18.04 20.04 22.04 23.04 23.10 daily-live
PR
 - Releases: 18.04 20.04 22.04 23.04 23.10 daily-live
ubuntustudio
Upstream
 - Releases: 16.04 18.04 20.04 22.04 23.04 23.10 jammy-daily daily-live daily-canary daily-legacy                                                                        
PR
 - Releases: 16.04 18.04 20.04 22.04 23.04 23.10 daily-live daily-legacy jammy-daily                                
ubuntu-unity
Upstream
 - Releases: 23.04 23.10 daily-live daily-canary
PR
 - Releases: 23.04 23.10 daily-live
xubuntu
Upstream
 - Releases: 16.04 18.04 20.04 22.04 23.04 23.10 jammy-daily daily-live daily-canary daily-legacy                                                                        
PR
 - Releases: 16.04 18.04 20.04 22.04 23.04 23.10 daily-live daily-legacy jammy-daily

Jai-JAP · 2023-11-15T02:26:06Z

@philclifford Edubuntu is fixed now.

- Remove obsolete daily-legacy - Add error if desktop amd64 build do not exist as in current status

* Automatic fetching of ubuntu versions * Fix displaying ubuntu versions * Update quickget * Updated quickget - Remove obsolete daily-legacy - Add error if desktop amd64 build do not exist as in current status * Allow 'daily' as a valid release for ubuntu family * Better logic to fetch Ubuntu-server & failsafe

philclifford approved these changes Oct 24, 2023

View reviewed changes

Jai-JAP force-pushed the master branch from e010d98 to b0914ab Compare October 25, 2023 10:13

flexiondotorg requested changes Nov 9, 2023

View reviewed changes

Jai-JAP force-pushed the master branch from 3214a1a to 0d15de7 Compare November 9, 2023 15:08

flexiondotorg marked this pull request as draft November 10, 2023 10:29

flexiondotorg force-pushed the master branch 5 times, most recently from 716c252 to 99e7677 Compare November 10, 2023 16:11

Jai-JAP force-pushed the master branch 2 times, most recently from 23236f8 to 5a18c07 Compare November 10, 2023 19:18

Automatic fetching of ubuntu versions

0a511b5

Jai-JAP force-pushed the master branch from 5a18c07 to 0a511b5 Compare November 10, 2023 19:20

Jai-JAP requested a review from flexiondotorg November 10, 2023 19:23

philclifford approved these changes Nov 10, 2023

View reviewed changes

flexiondotorg marked this pull request as ready for review November 12, 2023 17:20

flexiondotorg requested a review from philclifford November 12, 2023 17:20

philclifford requested changes Nov 12, 2023

View reviewed changes

Fix displaying ubuntu versions

2868e9e

philclifford approved these changes Nov 14, 2023

View reviewed changes

Update quickget

7b87019

Jai-JAP added 3 commits November 15, 2023 07:58

Merge upstream master

b4e7b44

Updated quickget

7a395cb

- Remove obsolete daily-legacy - Add error if desktop amd64 build do not exist as in current status

Allow 'daily' as a valid release for ubuntu family

baef6da

Jai-JAP force-pushed the master branch from 6aee808 to fc720ac Compare November 16, 2023 10:14

Better logic to fetch Ubuntu-server & failsafe

d541f9a

Jai-JAP force-pushed the master branch from fc720ac to d541f9a Compare November 16, 2023 10:27

flexiondotorg merged commit 7a724e4 into quickemu-project:master Nov 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added automatic version fetching for ubuntu #821

Added automatic version fetching for ubuntu #821

Jai-JAP commented Oct 24, 2023

philclifford commented Oct 24, 2023

Jai-JAP commented Oct 24, 2023

Jai-JAP commented Oct 24, 2023

philclifford commented Oct 24, 2023

flexiondotorg left a comment

Jai-JAP commented Nov 9, 2023 •

edited

Loading

flexiondotorg commented Nov 10, 2023

Jai-JAP commented Nov 10, 2023

philclifford left a comment

philclifford Nov 12, 2023

Jai-JAP Nov 13, 2023

Jai-JAP commented Nov 13, 2023

Jai-JAP commented Nov 14, 2023

philclifford commented Nov 14, 2023

Jai-JAP commented Nov 15, 2023

Added automatic version fetching for ubuntu #821

Added automatic version fetching for ubuntu #821

Conversation

Jai-JAP commented Oct 24, 2023

philclifford commented Oct 24, 2023

Jai-JAP commented Oct 24, 2023

Jai-JAP commented Oct 24, 2023

philclifford commented Oct 24, 2023

flexiondotorg left a comment

Choose a reason for hiding this comment

Jai-JAP commented Nov 9, 2023 • edited Loading

flexiondotorg commented Nov 10, 2023

Jai-JAP commented Nov 10, 2023

philclifford left a comment

Choose a reason for hiding this comment

philclifford Nov 12, 2023

Choose a reason for hiding this comment

Jai-JAP Nov 13, 2023

Choose a reason for hiding this comment

Jai-JAP commented Nov 13, 2023

Jai-JAP commented Nov 14, 2023

philclifford commented Nov 14, 2023

Jai-JAP commented Nov 15, 2023

Jai-JAP commented Nov 9, 2023 •

edited

Loading